Fixing some minor typos in the docs #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonnesbeck
reviewed
Jan 12, 2018
docs/source/gp.rst
Outdated
| @@ -244,7 +244,7 @@ also need to include the additional arguments, :code:`X`, :code:`y`, and | |||
| This second block produces the conditional distributions. Notice that extra | |||
| arguments are required for conditionals of :math:`f1` and :math:`f2`, but not | |||
| :math:`f`. This is because those arguments are cached when calling | |||
| :code:`.marginal_likelihood` was called on :code:`gp`. | |||
| :code:`.marginal_likelihood` on :code:`gp`. | |||
There was a problem hiding this comment.
I think the original is correct here: "...are cached when calling marginal likelihood on gp."
There was a problem hiding this comment.
My thinking when I read the sentence was that the action "to be called" was repeated and that one copy should be removed, but since I'm not familiar with the code at all it's completely possible I misinterpreted the statement, and "calling .marginal_likelihood" (as a gerund) is what is actually called on gp.
There was a problem hiding this comment.
I see. Could say “are cached when marginal_likelihood is called on gp.” instead.
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.