Fix image link (not showing up on the web)

[davidbrochart]

The image was pointing to local smc.png file, and not showing in https://docs.pymc.io/notebooks/SMC2_gaussians.html.

[review-notebook-app]

Check out this pull request on ReviewNB: https://app.reviewnb.com/pymc-devs/pymc3/pull/3454

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

[twiecki]

Thanks!

[davidbrochart]

Actually, I can see here that it fetches the image there:

<img alt="../_images/notebooks_SMC2_gaussians_14_0.png" src="../_images/notebooks_SMC2_gaussians_14_0.png" />

So I don't think my change will fix anything.

[davidbrochart]

The image could be embedded in the notebook:

from IPython.display import Image
Image('smc.png')

But that can't be in the same markdown cell.
Otherwise I don't know how the online documentation is created from the notebook.
cc @aloctavodia

[ColCarroll]

I still do not understand why your change did not work. In the radon example, a markdown image is used:

![radon](https://www.cgenarchive.org/uploads/2/5/2/6/25269392/7758459_orig.jpg)

I do not understand how that would be different from what you already did?

[davidbrochart]

Yes but https://docs.pymc.io/notebooks/SMC2_gaussians.html has this line:

<img alt="../_images/notebooks_SMC2_gaussians_14_0.png" src="../_images/notebooks_SMC2_gaussians_14_0.png" />

instead of:

<img alt="https://github.com/pymc-devs/pymc3/raw/master/docs/source/notebooks/smc.png" src="https://github.com/pymc-devs/pymc3/raw/master/docs/source/notebooks/smc.png" />

I don't know how this static HTML file is built from the notebook.

[ColCarroll]

Oh shoot. I wrote that 🤦‍♂️. I think markdown/html should be just rendered as markdown/html, but let me go find the right code.

[ColCarroll]

On review this code only creates the gallery, it does not do the notebook --> html conversion.

Looks like we use nbsphinx. These are the docs for markdown cells, and there is a binder link at the top to the notebook that generates the doc. They also do a remote image with a markdown tag instead of raw html, so maybe we try that?

Remote image: ![Python logo (remote)](https://www.python.org/static/img/python-logo-large.png)

[davidbrochart]

Even a local image seems to work:

Local image: ![Jupyter notebook icon](images/notebook_icon.png)

But one or the other, the documentation build has to be triggered, is it done when there is a release?

[ColCarroll]

I need more coffee. So this original PR was fine, I guess?

Yes, the build has to be triggered, and we started only triggering doc builds manually on a release.

We're planning to cut a release soon. Should we revert-revert this? @twiecki?

[davidbrochart]

Maybe the original PR was fine. It would be good to trigger the doc build locally to check.

[ColCarroll]

I'll try to remember that tonight (~8hrs). I have a server for testing doc builds.

I'll ping when it is up there.

[ColCarroll]

Somehow this doesn't make the image show up. I edited locally to the markdown image tag, and that one works:
https://pymc3.colindcarroll.com/notebooks/SMC2_gaussians.html

[ColCarroll]

Do you have time to make that PR, or want me to send one in?

[davidbrochart]

Done in #3455.