-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added backend option for VI sample trace #3557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would link to the issue instead of the PR in the release notes.
RELEASE-NOTES.md
Outdated
@@ -8,6 +8,7 @@ | |||
- Sequential Monte Carlo - Approximate Bayesian Computation step method is now available. The implementation is in an experimental stage and will be further improved. | |||
- Added `Matern12` covariance function for Gaussian processes. This is the Matern kernel with nu=1/2. | |||
- Progressbar reports number of divergences in real time, when available [#3547](https://github.com/pymc-devs/pymc3/pull/3547). | |||
- Sampling from variational approximation now allows for alternative trace backends [#3557]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Sampling from variational approximation now allows for alternative trace backends [#3557]. | |
- Sampling from variational approximation now allows for alternative trace backends ([issue 3550](https://github.com/pymc-devs/pymc3/issues/3550)) |
One other thing, issue #3550 also requests something like this to be done on sample prior and posterior predictive. I think we should leave the issue open after we merge this |
I can do the same for sample_prior_predictive. Shouldn't be too hard. |
Allows VI samples to be saved to non-ndarray backends, as requested by #3550.