Fix issue 3793 #3843
Merged
Fix issue 3793 #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3843 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 135 135
Lines 21152 21159 +7
=======================================
+ Hits 19194 19201 +7
Misses 1958 1958
|
Use Model.name_for() to relativize pm.Data names.
|
OK, this is good to go. Will someone please review and merge? |
|
@twiecki I updated the release notes.. merge? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give pm.Data objects model-relative names, using the same procedure as is used for random variables.
This is necessary to make pm.Data work properly when there are submodels.