Change draws and tune defaults to 1000 in pm.sample #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
- Coverage 90.75% 90.72% -0.04%
==========================================
Files 135 135
Lines 21184 21190 +6
==========================================
- Hits 19226 19224 -2
- Misses 1958 1966 +8
|
|
I’m not sure I can think of any tests that are relevant here, but the change seems big enough that I think one of @fonnesbeck or @twiecki should chime in before merging. |
ericmjl
approved these changes
Mar 26, 2020
ericmjl
approved these changes
Mar 26, 2020
twiecki
requested changes
Mar 27, 2020
AlexAndorra
changed the title
|
LGTM. Will wait for Thomas, though. |
|
Need a note in release-notes. |
|
Done |
twiecki
reviewed
Mar 30, 2020
|
Thanks for taking the initiative @AlexAndorra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3854, this PR proposes to change defaults values of
drawsandtuneinpm.sampleto 1000 and 2000 respectively -- both are currently at 500.I also cleaned some PEP8 typos in sampling.py.
Happy to make deeper changes if needed, and thanks in advance for the reviews ✌️