Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dirichlet.logp #4454

Merged
merged 5 commits into from
Feb 6, 2021
Merged

Fix Dirichlet.logp #4454

merged 5 commits into from
Feb 6, 2021

Conversation

Sayam753
Copy link
Member

@Sayam753 Sayam753 commented Feb 1, 2021 •
edited
Loading

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes?
    Fixes Issue with sampling from batches of Dirichlet distributions #4452
  • important background, or details about the implementation
    Compute Dirichlet.logp by checking for number of categories > 1 only at event dims (as per wiki page).
  • are the changes—especially new features—covered by tests and docstrings?
    Yes
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

@Sayam753
Copy link
Member Author

Sayam753 commented Feb 1, 2021 •
edited
Loading

This is the first time I am seeing a workflow running over 1.5 hours. Am I missing something? (EDIT - It took around 2 hours 15 minutes to finish the entire workflow)

@Sayam753 Sayam753 changed the title Fix Dirichlet.logp by checking number of categories > 1 only at event… Fix Dirichlet.logp Feb 1, 2021
@ricardoV94 ricardoV94 mentioned this pull request Feb 1, 2021
Closed
@michaelosthege michaelosthege added this to the vNext (3.11.1) milestone Feb 2, 2021
brandonwillard
brandonwillard suggested changes Feb 2, 2021
View reviewed changes
pymc3/tests/test_distributions.py Outdated Show resolved Hide resolved
@brandonwillard brandonwillard mentioned this pull request Feb 2, 2021
Closed
brandonwillard
brandonwillard approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests check out, I'm good with these changes.

brandonwillard
brandonwillard suggested changes Feb 3, 2021
View reviewed changes
pymc3/tests/test_distributions.py Outdated Show resolved Hide resolved
brandonwillard
brandonwillard suggested changes Feb 4, 2021
View reviewed changes
pymc3/tests/test_distributions.py Outdated Show resolved Hide resolved
@brandonwillard
Copy link
Contributor

@Sayam753, this needs to be rebased before squashing and merging.

@Sayam753 Sayam753 merged commit 0c21de4 into pymc-devs:master Feb 6, 2021
@Sayam753
Copy link
Member Author

Sayam753 commented Feb 6, 2021

Thanks @brandonwillard for helpful reviews.

@Sayam753 Sayam753 deleted the fix-dirichlet-logp branch August 16, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonwillard brandonwillard brandonwillard approved these changes

@AlexAndorra AlexAndorra Awaiting requested review from AlexAndorra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.

Issue with sampling from batches of Dirichlet distributions
3 participants
@Sayam753 @brandonwillard @michaelosthege