Implement backwards-compatible shape and dims with Ellipsis support #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
commented
May 14, 2021
twiecki
commented
May 14, 2021
michaelosthege
force-pushed
the
reintro_shape
branch
from
4f92f9f
to
ce96c84
Compare
michaelosthege
changed the title
michaelosthege
changed the title
michaelosthege
force-pushed
the
reintro_shape
branch
2 times, most recently
from
2f124df
to
51a0f0b
Compare
ricardoV94
reviewed
May 15, 2021
Closed
twiecki
commented
May 15, 2021
|
I think this looks great! |
|
Just changed base to |
michaelosthege
force-pushed
the
reintro_shape
branch
from
51a0f0b
to
fbcce93
Compare
|
After rebasing I'm now pushing this branch commit by commit, so we get CI results on all of them. |
ricardoV94
reviewed
May 15, 2021
michaelosthege
force-pushed
the
reintro_shape
branch
from
978017e
to
32822b7
Compare
twiecki
commented
May 15, 2021
|
Let me try and finish up the shape.py PR soon.
…On Sun, May 23, 2021, 14:39 Oriol Abril-Pla ***@***.***> wrote:
+1 on merging, further improvement and simplification can come in
follow-up PRs, I don't think there is discussion in terms of functionality
anymore so future PRs should not have any visible effect.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4696 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGEVCRWV3P5MVXT5RUDTPDZRNANCNFSM44342NCA>
.
|
michaelosthege
force-pushed
the
reintro_shape
branch
from
08cbb33
to
ab5f44f
Compare
Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
Co-authored-by: Ricardo <ricardo.vieira1994@gmail.com> Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com> Co-authored-by: Ricardo <ricardo.vieira1994@gmail.com>
michaelosthege
force-pushed
the
reintro_shape
branch
from
669a6e7
to
fda8cbc
Compare
Co-authored-by: Michael Osthege <m.osthege@fz-juelich.de>
michaelosthege
force-pushed
the
reintro_shape
branch
from
fda8cbc
to
8bdc225
Compare
|
As we decided in todays lab meeting is rebased this branch so we can merge it. There were quite a few git conflicts, as anticipated, but it looks like nothing broke. |
michaelosthege
requested review from
OriolAbril,
canyon289,
fonnesbeck,
junpenglao and
Sayam753
|
OK good to merge from my end!
…On Fri, Jun 4, 2021, 19:01 Michael Osthege ***@***.***> wrote:
As we decided in todays lab meeting
<https://github.com/pymc-devs/pymc3/wiki/Project-Meeting-Minutes#friday-june-4-2021>
is rebased this branch so we can merge it.
There were quite a few git conflicts, as anticipated, but it looks like
nothing broke.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4696 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGHAFFJYKZERNMY25OTTREBHLANCNFSM44342NCA>
.
|
OriolAbril
previously approved these changes
Jun 4, 2021
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
|
Thanks to everyone who helped get this over the finish line, especially the herculean efforts of @michaelosthege! Also thanks for helpful review from @brandonwillard, @ricardoV94, @OriolAbril and everyone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is what I did:
Create a diff between #4693 and #4667 and stage that diff onto a branch off of #4693 (no conflicts!). I then ran
git commit -pand only selected those that seemed necessary here. Mostly there were some changes to tests that changedsizetoshapeI did not commit.Remember: Before merging still need to change author to @michaelosthege.