Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair the plot of pm.Interpolated and add an example for pm.Deterministic #6126

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

Armavica
Copy link
Member

This PR closes #6124 by adding an example and explanation of pm.Deterministic.

It also repairs the plot of pm.Interpolated which was not working, and fixes some of the doc makefile commands.

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • Fix make serve
  • Fix make html
  • Fix make clean
  • Repair the plot of pm.Interpolated
  • Add an explanation and example to pm.Deterministic

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #6126 (c032d6e) into main (bbb3082) will decrease coverage by 0.48%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6126      +/-   ##
==========================================
- Coverage   91.02%   90.54%   -0.49%     
==========================================
  Files          99      102       +3     
  Lines       20531    21241     +710     
==========================================
+ Hits        18689    19233     +544     
- Misses       1842     2008     +166     
Impacted Files Coverage 螖
pymc/distributions/continuous.py 97.51% <酶> (酶)
pymc/distributions/transforms.py 100.00% <酶> (酶)
pymc/model.py 88.23% <酶> (酶)
pymc/variational/test_functions.py 38.09% <0.00%> (-61.91%) 猬囷笍
pymc/variational/stein.py 48.33% <0.00%> (-51.67%) 猬囷笍
pymc/variational/operators.py 57.14% <0.00%> (-35.72%) 猬囷笍
pymc/variational/inference.py 50.77% <0.00%> (-35.32%) 猬囷笍
pymc/variational/approximations.py 54.79% <0.00%> (-32.53%) 猬囷笍
pymc/variational/callbacks.py 78.00% <0.00%> (-18.00%) 猬囷笍
pymc/variational/opvi.py 75.20% <0.00%> (-11.85%) 猬囷笍
... and 19 more

pymc/model.py Outdated Show resolved Hide resolved
@ricardoV94
Copy link
Member

My review concerns the changes in docstrings, not the changes to the makerfile

@Armavica Armavica added the docs label Sep 14, 2022
@ricardoV94 ricardoV94 merged commit 78dd40f into pymc-devs:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The docs for deterministic should include an example
3 participants