Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass size to specialized truncated dispatch #6165

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Sep 30, 2022

Closes #6156

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • Fix shape bug when creating a specialized TruncatedNormal via Truncated

Docs / Maintenance

  • ...

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #6165 (6088c26) into main (4836bc1) will increase coverage by 15.30%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6165       +/-   ##
===========================================
+ Coverage   77.72%   93.03%   +15.30%     
===========================================
  Files          91       91               
  Lines       20780    20789        +9     
===========================================
+ Hits        16152    19341     +3189     
+ Misses       4628     1448     -3180     
Impacted Files Coverage Δ
pymc/tests/distributions/test_truncated.py 99.48% <90.90%> (-0.52%) ⬇️
pymc/distributions/truncated.py 99.30% <100.00%> (ø)
pymc/sampling.py 82.19% <0.00%> (+0.10%) ⬆️
pymc/model.py 88.23% <0.00%> (+0.13%) ⬆️
pymc/variational/opvi.py 87.04% <0.00%> (+0.16%) ⬆️
pymc/math.py 70.04% <0.00%> (+0.48%) ⬆️
pymc/step_methods/hmc/base_hmc.py 90.55% <0.00%> (+0.78%) ⬆️
pymc/distributions/mixture.py 95.40% <0.00%> (+2.87%) ⬆️
pymc/distributions/distribution.py 95.90% <0.00%> (+4.54%) ⬆️
pymc/distributions/dist_math.py 87.42% <0.00%> (+9.14%) ⬆️
... and 8 more

@ricardoV94 ricardoV94 added the bug label Sep 30, 2022
@ricardoV94 ricardoV94 merged commit 244c37d into pymc-devs:main Sep 30, 2022
@ricardoV94 ricardoV94 deleted the fix_truncated_normal branch June 6, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shape bug for observed truncated normal distribution initialized via pm.Truncated
3 participants