Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in the overview notebook #6274

Merged
merged 1 commit into from Nov 8, 2022
Merged

Conversation

grtyvr
Copy link

@grtyvr grtyvr commented Nov 7, 2022

Fixed a small typo where 'sd' was used instead of 'sigma' in describing pd.Normal paramaters.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ricardoV94
Copy link
Member

@grtyvr thanks for the fix. Can I ask you to add and fill the default PR layout on the top message?

Specifically the bullet point with ”Maintenance/Docs”. This is so you get proper credit in the automatic release notes.

https://github.com/pymc-devs/pymc/blob/main/.github/PULL_REQUEST_TEMPLATE.md

@michaelosthege
Copy link
Member

Specifically the bullet point with ”Maintenance/Docs”. This is so you get proper credit in the automatic release notes.

The text from the PR description is not automatically used, but just meant for us maintainers so we can quickly categorize, and copy/paste more details into the release notes if needed.

By defaulty (by automation) the PR title becomes the entry in the release notes.

@michaelosthege michaelosthege merged commit f80e45c into pymc-devs:main Nov 8, 2022
@michaelosthege michaelosthege changed the title fixed small typo Fixed a typo in the overview notebook Nov 8, 2022
@ricardoV94
Copy link
Member

The text from the PR description is not automatically used, but just meant for us maintainers so we can quickly categorize, and copy/paste more details into the release notes if needed.

It does try to guess which category it is? Or is it based on labels alone?

@michaelosthege
Copy link
Member

only based on the labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants