Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add informative error if user tries to use Aesara function with PyTensor variables #6440

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jan 6, 2023

Since the cure was worse than the disease...

Closes #6434

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #6440 (a78cc12) into main (b081cec) will increase coverage by 8.68%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6440      +/-   ##
==========================================
+ Coverage   86.05%   94.74%   +8.68%     
==========================================
  Files         148      148              
  Lines       27646    27639       -7     
==========================================
+ Hits        23792    26187    +2395     
+ Misses       3854     1452    -2402     
Impacted Files Coverage Δ
pymc/pytensorf.py 92.32% <ø> (+0.59%) ⬆️
pymc/logprob/cumsum.py 100.00% <0.00%> (+3.12%) ⬆️
pymc/tests/logprob/utils.py 50.00% <0.00%> (+3.65%) ⬆️
pymc/logprob/rewriting.py 97.05% <0.00%> (+5.88%) ⬆️
pymc/logprob/abstract.py 97.56% <0.00%> (+6.09%) ⬆️
pymc/logprob/utils.py 100.00% <0.00%> (+13.79%) ⬆️
pymc/logprob/joint_logprob.py 97.01% <0.00%> (+19.40%) ⬆️
pymc/logprob/tensor.py 82.40% <0.00%> (+24.00%) ⬆️
pymc/logprob/transforms.py 96.42% <0.00%> (+28.63%) ⬆️
pymc/logprob/censoring.py 100.00% <0.00%> (+29.89%) ⬆️
... and 15 more

@twiecki twiecki merged commit 029d548 into pymc-devs:main Jan 6, 2023
@ricardoV94 ricardoV94 deleted the revert_aesara_error branch January 6, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: AmbiguityWarning: Ambiguities exist in dispatched function _unify
3 participants