Improved docstring for predictions argument in sample_posterior_predictive #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canyon289
reviewed
Mar 22, 2023
canyon289
approved these changes
Mar 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6616 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 93 93
Lines 15742 15742
=======================================
Hits 14485 14485
Misses 1257 1257
|
OriolAbril
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The current docstring for
predictions=insample_posterior_predictionhas been the source of some confusion, as it does not adequately describe what is going on. This PR aims to address this and provide a clearer picture of what it is for.Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance