Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectification in MeasurableCheckAndRiase and tests #6698

Closed
wants to merge 3 commits into from

Conversation

Dhruvanshu-Joshi
Copy link
Contributor

@Dhruvanshu-Joshi Dhruvanshu-Joshi commented Apr 29, 2023

What is this PR about?
This PR aims to provide details of the approaches that I tried to solve the issue #6684. There were some errors in pymc/logprob/checks.py and tests/logprob/test_checks.py which this PR aims to solve.

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

馃摎 Documentation preview 馃摎: https://pymc--6698.org.readthedocs.build/en/6698/

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #6698 (26d0664) into main (a617bf2) will increase coverage by 2.44%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6698      +/-   ##
==========================================
+ Coverage   89.57%   92.01%   +2.44%     
==========================================
  Files          95       95              
  Lines       16131    16130       -1     
==========================================
+ Hits        14449    14842     +393     
+ Misses       1682     1288     -394     
Impacted Files Coverage 螖
pymc/logprob/checks.py 68.00% <50.00%> (+1.33%) 猬嗭笍

... and 5 files with indirect coverage changes

@ricardoV94
Copy link
Member

Solved in #6746

@ricardoV94 ricardoV94 closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants