Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pymc_overview.ipynb #6925

Merged
merged 2 commits into from Sep 24, 2023
Merged

Conversation

thompsonjjet23
Copy link
Contributor

@thompsonjjet23 thompsonjjet23 commented Sep 22, 2023

This PR addresses the docs typo raised here: #6860


馃摎 Documentation preview 馃摎: https://pymc--6925.org.readthedocs.build/en/6925/

Fix typo in overview notebook
@welcome
Copy link

welcome bot commented Sep 22, 2023

Thank You Banner
馃挅 Thanks for opening this pull request! 馃挅 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@review-notebook-app
Copy link

Check out this pull request on聽 ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 23, 2023

View / edit / reply to this conversation on ReviewNB

larryshamalama commented on 2023-09-23T18:34:59Z
----------------------------------------------------------------

Thanks for your PR :)

maybe let's be a bit more clear while at it? "...to sample our parameters instead of NUTS..."

Otherwise, looks good to be merged!


@thompsonjjet23
Copy link
Contributor Author

Check out this pull request on聽 ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@larryshamalama thanks for the review! i updated the language to say "to sample our parameters"

@twiecki twiecki merged commit 54269df into pymc-devs:main Sep 24, 2023
10 checks passed
@welcome
Copy link

welcome bot commented Sep 24, 2023

Congratulations Banner
Congrats on merging your first pull request! 馃帀 We here at PyMC are proud of you! 馃挅 Thank you so much for your contribution 馃巵

@twiecki
Copy link
Member

twiecki commented Sep 24, 2023

Thanks @thompsonjjet23!

@ricardoV94 ricardoV94 changed the title Update pymc_overview.ipynb Fix typo in pymc_overview.ipynb Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants