GP do not fail when xdims cannot be constant folded #7111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7111 +/- ##
==========================================
- Coverage 90.20% 85.66% -4.54%
==========================================
Files 101 101
Lines 16961 16961
==========================================
- Hits 15299 14530 -769
- Misses 1662 2431 +769
|
ricardoV94
reviewed
Jan 23, 2024
pymc/gp/cov.py
Outdated
| ) | ||
| try: | ||
| # For the HSGP.prior_linearized use case, it's OK if X is not constant. | ||
| [xdims] = constant_fold([xdims], raise_not_constant=True) |
There was a problem hiding this comment.
You can change to raise_not_constant=False, no point in having a try except
ricardoV94
reviewed
Jan 26, 2024
ricardoV94
force-pushed
the
hsgp-linearized-fix
branch
2 times, most recently
from
02f190d
to
9c5cd15
Compare
ricardoV94
added
docs
maintenance
GP
ricardoV94
changed the title
ricardoV94
changed the title
ricardoV94
force-pushed
the
hsgp-linearized-fix
branch
from
9c5cd15
to
440079b
Compare
ricardoV94
approved these changes
Feb 6, 2024
|
@bwengals I rebased the PR and split the two logical commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7000. Going with @ricardoV94's suggestion of try/except, from the comments in that issue.
Related Issue
HSGP.prior_linearizedexample raises error #7000Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7111.org.readthedocs.build/en/7111/