Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in dataset_to_point_list when chain, draw are not the leading dims #7180

Merged
merged 3 commits into from Mar 1, 2024

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Feb 29, 2024

Description

Split the dict comprehension in two to keep transposing and reshaping coherent.
Otherwise, the sizes used in the reshaping are taken from the object before transposing
and the function doesn't work whenever the transposing is actually needed.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7180.org.readthedocs.build/en/7180/

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (6c6fd13) to head (d3e0908).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7180   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         100      100           
  Lines       16887    16888    +1     
=======================================
+ Hits        15577    15578    +1     
  Misses       1310     1310           
Files Coverage Δ
pymc/util.py 80.93% <100.00%> (+0.08%) ⬆️

@ricardoV94
Copy link
Member

mypy is unhappy

pymc/util.py Outdated Show resolved Hide resolved
pymc/util.py Outdated Show resolved Hide resolved
pymc/util.py Outdated Show resolved Hide resolved
@OriolAbril
Copy link
Member Author

I could only find 9ne failed test which seems unrelated (checking from my phone)

@ricardoV94
Copy link
Member

I could only find 9ne failed test which seems unrelated (checking from my phone)

Rerunning

@ricardoV94 ricardoV94 added the bug label Mar 1, 2024
@ricardoV94 ricardoV94 changed the title fix dataset_to_point_list Fix error in dataset_to_point_list with unconventional position of sample dims Mar 1, 2024
@ricardoV94 ricardoV94 changed the title Fix error in dataset_to_point_list with unconventional position of sample dims Fix error in dataset_to_point_list when chain, draw are not the leading dims Mar 1, 2024
@ricardoV94 ricardoV94 merged commit 35ccca5 into pymc-devs:main Mar 1, 2024
23 checks passed
@OriolAbril OriolAbril deleted the transpose_fix branch March 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataset_to_point_list fails when chain, draw are not the leading dims
2 participants