Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyTensor dependency and drop support for python 3.9 #7227

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 28, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7227.org.readthedocs.build/en/7227/

@ricardoV94 ricardoV94 added release pytensor major Include in major changes release notes section labels Mar 28, 2024
@ricardoV94 ricardoV94 requested a review from maresb March 28, 2024 18:48
Copy link
Member

@Armavica Armavica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you miss the python_requires line in setup.py?

There is also python_version in mypy.ini and tool.ruff.target-version in pyproject.toml but this will make pre-commit unhappy so I am happy to clean these up in another PR

@ricardoV94 ricardoV94 mentioned this pull request Mar 28, 2024
2 tasks
@ricardoV94 ricardoV94 changed the title Drop support for python 3.9 Bump PyTensor dependency and drop support for python 3.9 Mar 28, 2024
@ricardoV94
Copy link
Member Author

Did you miss the python_requires line in setup.py?

There is also python_version in mypy.ini and tool.ruff.target-version in pyproject.toml but this will make pre-commit unhappy so I am happy to clean these up in another PR

Thanks, updated it.

@ricardoV94
Copy link
Member Author

@Armavica do you want to update the mypy / pre-commit version? Feel free to push to this branch

@ricardoV94
Copy link
Member Author

Seems like something is broken :D

@Armavica
Copy link
Member

Yes, I don't really understand what… I tried a few of the tests that fail here and they work on my machine, and I don't really understand this mamba error on pre-commit either

@ricardoV94
Copy link
Member Author

Are you running with the newer Pytensor?

@Armavica
Copy link
Member

Are you running with the newer Pytensor?

Ok I can reproduce now 🤦‍♂️

@ricardoV94
Copy link
Member Author

I'll try and fix next week, probably my fault anyway :)

@maresb
Copy link
Contributor

maresb commented Mar 29, 2024

We should switch to setup-micromamba. I did that recently but I forget where.

@Armavica
Copy link
Member

here probably? #7213

@maresb
Copy link
Contributor

maresb commented Mar 29, 2024

Ah ya, thanks! That's the one!

@ricardoV94 ricardoV94 force-pushed the bump-pytensor-version branch 2 times, most recently from c247bdd to 4915607 Compare April 5, 2024 07:59
@ricardoV94
Copy link
Member Author

Tests are passing now, except mypy installation failing.

@maresb what should we do, re-release PyTensor and combine this PR with #7213 ?

@ricardoV94
Copy link
Member Author

This is the error:

  LibMambaUnsatisfiableError: Encountered problems while solving:
    - package pytensor-2.20.0-py310hc6cd4ac_0 requires python >=3.10,<3.11.0a0, but none of the providers can be installed
  
  Could not solve for environment specs
  The following packages are incompatible
  ├─ pytensor >=2.20,<2.21  is installable with the potential options
  │  ├─ pytensor 2.20.0 would require
  │  │  ├─ python >=3.10,<3.11.0a0 , which can be installed;
  │  │  └─ python_abi 3.10.* *_cp310, which can be installed;
  │  ├─ pytensor 2.20.0 would require
  │  │  ├─ python >=3.11,<3.12.0a0 , which can be installed;
  │  │  └─ python_abi 3.11.* *_cp311, which can be installed;
  │  └─ pytensor 2.20.0 would require
  │     └─ python_abi 3.12.* *_cp312, which can be installed;
  └─ python 3.9**  is not installable because there are no viable options
     ├─ python [3.9.0|3.9.1|...|3.9.7] conflicts with any installable versions previously reported;
     └─ python [3.9.0|3.9.1|...|3.9.9] would require
        └─ python_abi 3.9.* *_cp39, which conflicts with any installable versions previously reported.
  
  
  
  LibMambaUnsatisfiableError: Encountered problems while solving:
    - package pytensor-2.20.0-py310hc6cd4ac_0 requires python >=3.10,<3.11.0a0, but none of the providers can be installed
  
  Could not solve for environment specs
  The following packages are incompatible
  ├─ pytensor >=2.20,<2.21  is installable with the potential options
  │  ├─ pytensor 2.20.0 would require
  │  │  ├─ python >=3.10,<3.11.0a0 , which can be installed;
  │  │  └─ python_abi 3.10.* *_cp310, which can be installed;
  │  ├─ pytensor 2.20.0 would require
  │  │  ├─ python >=3.11,<3.12.0a0 , which can be installed;
  │  │  └─ python_abi 3.11.* *_cp311, which can be installed;
  │  └─ pytensor 2.20.0 would require
  │     └─ python_abi 3.12.* *_cp312, which can be installed;
  └─ python 3.9**  is not installable because there are no viable options
     ├─ python [3.9.0|3.9.1|...|3.9.7] conflicts with any installable versions previously reported;
     └─ python [3.9.0|3.9.1|...|3.9.9] would require
        └─ python_abi 3.9.* *_cp39, which conflicts with any installable versions previously reported.

What is restricted to 3.9?

@ricardoV94
Copy link
Member Author

Ah I think we just need to tweak the python version in the pre-commit workflow

@ricardoV94
Copy link
Member Author

Tests are passing

@twiecki twiecki merged commit bd74474 into pymc-devs:main Apr 5, 2024
21 checks passed
@ricardoV94 ricardoV94 deleted the bump-pytensor-version branch April 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section pytensor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants