Allow freezing only subset of data and dims #7248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
freeze_dims_data_enh
branch
2 times, most recently
from
6c070e1
to
88d1052
Compare
|
One day mypy will be useful, today is not that day |
ricardoV94
force-pushed
the
freeze_dims_data_enh
branch
2 times, most recently
from
ecaf65b
to
9ad0b75
Compare
zaxtax
reviewed
Apr 21, 2024
*Also fix dim_lengths not being returned
ricardoV94
force-pushed
the
freeze_dims_data_enh
branch
from
9ad0b75
to
ac4e39b
Compare
Added that check to the first test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the optimization introduced on #7047, to allow freezing a subset of dims and data
It also fixes a bug where the dim_lengths were not returned
Checklist
Type of change
馃摎 Documentation preview 馃摎: https://pymc--7248.org.readthedocs.build/en/7248/