Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tools and build system to pyproject.toml #7382

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Jun 22, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7382.org.readthedocs.build/en/7382/

@Armavica Armavica changed the title Move everything to pyproject.toml Move tools and build system to pyproject.toml Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (c2c46a7) to head (04f9342).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7382   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         102      102           
  Lines       17190    17190           
=======================================
  Hits        15877    15877           
  Misses       1313     1313           

@Armavica Armavica marked this pull request as ready for review June 22, 2024 04:11
@Armavica Armavica requested a review from maresb June 22, 2024 04:12
@maresb
Copy link
Contributor

maresb commented Jun 22, 2024

I took a very quick look. Very exciting, but there's a problem:

$ python -m build .
...
Successfully built pymc-0.0.0.tar.gz and pymc-0.0.0-py3-none-any.whl

It's picking up the version as 0.0.0. In contrast, on main:

Successfully built pymc-5.15.1+52.gc2c46a764.tar.gz and pymc-5.15.1+52.gc2c46a764-py3-none-any.whl

@maresb maresb marked this pull request as draft June 22, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants