Add Normal mixture example, fixup check_toc script #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Dec 4, 2020
| @@ -41,7 +41,6 @@ repos: | |||
| entry: python scripts/check_toc_is_complete.py | |||
| language: python | |||
| name: Check all notebooks appear in table of contents | |||
| pass_filenames: false | |||
There was a problem hiding this comment.
My bad here, I erroneously added this in #4262 😳 This script does take file names though (via argparse)
MarcoGorelli
commented
Dec 4, 2020
Comment on lines
-8
to
+10
| import json | ||
| from pathlib import Path | ||
| import argparse | ||
| import ast |
There was a problem hiding this comment.
these aren't sorted, but their order will be sorted out with #4239 (which needs to have upstream/master merged anyway)
Codecov Report
@@ Coverage Diff @@
## master #4294 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 88 88
Lines 14341 14341
=======================================
Hits 12570 12570
Misses 1771 1771
|
twiecki
reviewed
Dec 4, 2020
|
|
||
| if __name__ == "__main__": | ||
| toc_examples = (Path("docs") / "source/notebooks/table_of_contents_examples.js").read_text() | ||
| toc_tutorials = (Path("docs") / "source/notebooks/table_of_contents_tutorials.js").read_text() | ||
| toc_keys = { | ||
| **json.loads(toc_examples[toc_examples.find("{") :]), |
There was a problem hiding this comment.
what was wrong with th eold way?
There was a problem hiding this comment.
if you included a trailing comma then you'd get a mysterious
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 69 column 1 (char 3689)
, while ast.literal_eval can handle trailing commas
|
This is great - thanks! |
twiecki
approved these changes
Dec 4, 2020
michaelosthege
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mixture examples aren't the most straightforward, so here's a simple Gaussian mixture example:
While I'm here, am also fixing up the check_toc script to use
ast.literval_evalinstead ofjson.loads, as the docs build fine with trailing commas in the js dicts and this way we won't get mysterious errors like this one @twiecki got when adding a trailing comma