Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Scan rewrite and tag names #793

Merged
merged 1 commit into from
May 31, 2024

Conversation

ricardoV94
Copy link
Member

Description

We were trying to test scan rewrites and hit again the fact that the name reported by the optimizer_verbose=True is not the name we can use to filter out rewrites due to the arbitrary custom names given. If we make them match the function it will work, because in2out gives the name of the function to the rewrite by default.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 marked this pull request as ready for review May 31, 2024 12:59
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (2143d85) to head (9f96ec9).
Report is 185 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files         163      163           
  Lines       46938    46940    +2     
  Branches    11497    11498    +1     
=======================================
+ Hits        37911    37913    +2     
  Misses       6785     6785           
  Partials     2242     2242           
Files with missing lines Coverage Δ
pytensor/link/numba/dispatch/scan.py 95.89% <ø> (ø)
pytensor/scan/rewriting.py 81.20% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 4948903 into pymc-devs:main May 31, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants