Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix dependencies #813

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Minor: Fix dependencies #813

merged 2 commits into from
Jun 10, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jun 9, 2024

Description

We no longer depend on typing-extensions, so let's remove it.

Also, to be somewhat pedantic, llvmlite should be an explicit dependency under the numba category.

This doesn't solve any current problem, but you know me, I like to be precise about the dependencies. 😂

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Even though llvmlite is a dependency of numba, we explicitly import it,
so for us it should count as a direct dependency.
maresb added a commit to maresb/pytensor-suite-feedstock that referenced this pull request Jun 9, 2024
@ricardoV94 ricardoV94 merged commit 6857517 into pymc-devs:main Jun 10, 2024
15 checks passed
@maresb maresb deleted the fix-dependencies branch June 10, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants