Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing doctests #323

Closed
drbenvincent opened this issue May 2, 2024 · 1 comment · Fixed by #330
Closed

Fix failing doctests #323

drbenvincent opened this issue May 2, 2024 · 1 comment · Fixed by #330
Assignees
Labels
bug Something isn't working

Comments

@drbenvincent
Copy link
Collaborator

We've currently got 12 failing doctests.

Initially I was unable to replicate the failing tests running make doctest locally. But after rebuilding the environment from scratch I did manage to replicate the failing tests. So the suspicion is that something has changed in a dependency.

I've not dug into the details too much, but possibly related to the expected outputs. Maybe a type hinting issue?

061     >>> model.fit(X, y)
Expected:
    Inference...
Got:
    <BLANKLINE>
    <BLANKLINE>
    Inference data with groups:
        > posterior
        > posterior_predictive
        > sample_stats
        > prior
        > prior_predictive
        > observed_data
        > constant_data

Tagging @jpreszler

@drbenvincent
Copy link
Collaborator Author

drbenvincent commented May 6, 2024

On rebuilding the environment, I'm getting pytensor build issues. So I believe that we had previously gotten away with a pip based method to build the environment, but since moving to pymc>=5.14.0 we aren't getting away with this any more.

So my prediction is that #304 is a blocker for tests/doctests to pass locally, and #281 may be a blocker for remote tests to pass. Prediction was incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant