Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing doctests #330

Merged
merged 2 commits into from
May 6, 2024
Merged

Fix failing doctests #330

merged 2 commits into from
May 6, 2024

Conversation

drbenvincent
Copy link
Collaborator

  • Closes Fix failing doctests #323 which is affecting current PR's.
  • Also managed to catch a bug where we were not passing in random_seed to pm.sample_posterior_predictive in ModelBuilder.predict. Also replaced a multi-line block with the single line random_seed = self.sample_kwargs.get("random_seed", None) which is much nicer.
  • Other than that, the solution was to add varying numbers of <BLANKLINE> to the docstrings. I believe this is because the pymc progress bar is returning empty lines, possibly only in the instance where progressbar=False. I should open an issue in the PyMC repo about that.
  • All tests and doctests pass in my local environment, which was build in the conda-based approach, see Move to a conda only install of pymc (local dev workflow) #304. Remains to be seen if the doctests will pass remotely.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (dbaa17b) to head (8805fb2).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   77.10%   77.27%   +0.17%     
==========================================
  Files          21       21              
  Lines        1380     1395      +15     
==========================================
+ Hits         1064     1078      +14     
- Misses        316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent
Copy link
Collaborator Author

Hurray! Remote tests pass 🎉

@drbenvincent drbenvincent merged commit 9169718 into main May 6, 2024
7 checks passed
@drbenvincent drbenvincent deleted the failing-doctests branch May 6, 2024 15:08
@drbenvincent drbenvincent added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing doctests
2 participants