Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pre-commit-ci #476

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Add support for pre-commit-ci #476

merged 1 commit into from
Jan 8, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jan 6, 2024

Motivated by #473

I suggest adding support for pre-commit-ci to automate the revision updates and potentially improve the dev experience by auto-fixing PRs. See docs: https://pre-commit.ci/. I added the defaults explicitly to have more control over the actions.

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--476.org.readthedocs.build/en/476/

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e826a9) 90.82% compared to head (0812e1f) 90.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          21       21           
  Lines        1972     1972           
=======================================
  Hits         1791     1791           
  Misses        181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622
Copy link
Contributor

wd60622 commented Jan 7, 2024

ruff has a v2 logo that is in their repo. Shown here

@juanitorduz
Copy link
Collaborator Author

ruff has a v2 logo that is in their repo. Shown here

Thanks @wd60622 ! I created a fix: #478

@twiecki twiecki merged commit ae7fd1b into main Jan 8, 2024
13 checks passed
@twiecki twiecki deleted the pre-commit-ci branch January 8, 2024 03:44
@maresb
Copy link
Contributor

maresb commented Jan 20, 2024

This PR was actually a no-op. It creates a config file with all the default settings. It would be useful for customizing the configuration in the future, but it could also be deleted.

I think the pre-commit docs suck (I've attempted PRs to improve them but was rejected). I'll explain the steps here for enabling pre-commit-ci for this repo.

  1. Visit https://pre-commit.ci/
  2. Click the big "Sign In With GitHub" button at the top
  3. If there's no organization available (e.g. in this case pymc-labs), then click "add an installation"
  4. Select the organization (pymc-labs)
  5. You get a menu for "Install, Authorize, & Request pre-commit ci".
  6. Select the repositories to add and click "Install Authorize & Request"

After entering your authentication code you should be all set.

I just did the procedure for this repo, so everything should be working now!

@juanitorduz
Copy link
Collaborator Author

Thank you very much @maresb 🤜🤛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants