Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit-ci hook #599

Closed
maresb opened this issue Jan 15, 2024 · 5 comments
Closed

Add pre-commit-ci hook #599

maresb opened this issue Jan 15, 2024 · 5 comments

Comments

@maresb
Copy link
Contributor

maresb commented Jan 15, 2024

We don't currently have any automatic mechanism for updating the version tags in .pre-commit-config.yaml. I think that we should use https://github.com/marketplace/pre-commit-ci. I think this should be straightforward for @ricardoV94 to enable.

EDIT: Strange... GitHub mangled my initial description, so I had to rewrite the above. 😞

@maresb maresb mentioned this issue Jan 15, 2024
5 tasks
@ricardoV94
Copy link
Member

@juanitorduz @maresb is this one taken care of?

@maresb
Copy link
Contributor Author

maresb commented Jan 20, 2024

I think I just enabled it:

image

@maresb
Copy link
Contributor Author

maresb commented Jan 20, 2024

Yes!

I restarted CI on #596 and it showed up:

image

Also, it's showing up under installed apps

@maresb maresb closed this as completed Jan 20, 2024
@juanitorduz
Copy link
Contributor

@maresb great! Could you help us with PyMC marketing? pymc-labs/pymc-marketing#476 What else do we need to do to make it work ?

@juanitorduz
Copy link
Contributor

@ricardoV94 @twiecki I think we need to give access to the app from the pymc-labs account right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants