Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot Waterfall Components Decomposition #631

Merged
merged 6 commits into from
Apr 28, 2024

Conversation

cetagostini-wise
Copy link
Contributor

@cetagostini-wise cetagostini-wise commented Apr 15, 2024

Description

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--631.org.readthedocs.build/en/631/

Co-Authored-By: Carlos Trujillo <59846724+cetagostini@users.noreply.github.com>
@cetagostini-wise cetagostini-wise changed the title Plot Waterfall Components Decomposition #625 Plot Waterfall Components Decomposition Apr 15, 2024
@cetagostini cetagostini self-requested a review April 15, 2024 21:15
@cetagostini cetagostini self-assigned this Apr 15, 2024
@cetagostini
Copy link
Contributor

cetagostini commented Apr 15, 2024

Any idea why PyPI / build source distribution (pull_request) is failing? @wd60622 @juanitorduz

@juanitorduz
Copy link
Collaborator

Any idea why PyPI / build source distribution (pull_request) is failing? @wd60622 @juanitorduz

I think it is related to pymc-devs/pymc-experimental#329 (comment) and pymc-devs/pymc-experimental@1f70c7a I will create a PR

@juanitorduz
Copy link
Collaborator

i think #633 solves it :D

@cetagostini-wise
Copy link
Contributor Author

@juanitorduz Perfect, I'll make the change!

@juanitorduz
Copy link
Collaborator

@juanitorduz Perfect, I'll make the change!

No need to! I will merge the fix and then you can update the branch from this PR very easily with the new "green button" :)

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cetagostini-wise Nice PR and easy to review! I added some small comments but overall looks great!

pymc_marketing/mmm/base.py Show resolved Hide resolved
pymc_marketing/mmm/base.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/base.py Show resolved Hide resolved
pymc_marketing/mmm/base.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/base.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/base.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/base.py Outdated Show resolved Hide resolved
tests/mmm/test_delayed_saturated_mmm.py Outdated Show resolved Hide resolved
@juanitorduz
Copy link
Collaborator

juanitorduz commented Apr 16, 2024

@cetagostini you can now push the "Update Branch" button ⬆️

@cetagostini
Copy link
Contributor

Ready for review @juanitorduz

@juanitorduz
Copy link
Collaborator

Thank you @cetagostini !

@juanitorduz juanitorduz merged commit 1c186f0 into pymc-labs:main Apr 28, 2024
9 checks passed
@juanitorduz
Copy link
Collaborator

@cetagostini do you want to do a following PR where you add this plot to the mmm example notebook?

@cetagostini
Copy link
Contributor

@cetagostini do you want to do a following PR where you add this plot to the mmm example notebook?

Sure, I'll make it @juanitorduz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants