-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot Waterfall Components Decomposition #631
Conversation
Co-Authored-By: Carlos Trujillo <59846724+cetagostini@users.noreply.github.com>
Any idea why |
I think it is related to pymc-devs/pymc-experimental#329 (comment) and pymc-devs/pymc-experimental@1f70c7a I will create a PR |
i think #633 solves it :D |
@juanitorduz Perfect, I'll make the change! |
No need to! I will merge the fix and then you can update the branch from this PR very easily with the new "green button" :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cetagostini-wise Nice PR and easy to review! I added some small comments but overall looks great!
@cetagostini you can now push the "Update Branch" button ⬆️ |
Ready for review @juanitorduz |
Thank you @cetagostini ! |
@cetagostini do you want to do a following PR where you add this plot to the mmm example notebook? |
Sure, I'll make it @juanitorduz |
Description
Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--631.org.readthedocs.build/en/631/