Check if the episode is a key of the searchResults before sending it #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for searched_episode in searched_episode_list: | ||
| if searched_episode in [x for x, _ in searchResults.items()]: | ||
| results = curProvider.cache.update_cache_manual_search(searchResults[searched_episode]) | ||
| if results is not None: |
There was a problem hiding this comment.
yeah i'll change that
p0psicles
changed the title
fernandog
force-pushed
the
fix-manual-snatch-keynotfound
branch
2 times, most recently
from
f081801
to
d061607
Compare
|
Approved! |
| @@ -583,12 +583,12 @@ def searchProviders(show, episodes, manualSearch=False, downCurQuality=False, ma | |||
| searched_episode_list = [episode_obj.episode for episode_obj in episodes] | |||
| # Add the -1 to also match season pack results | |||
| searched_episode_list.append(-1) | |||
| episodes_search_result = [x for x, _ in searchResults.items()] | |||
| episodes_search_result = list(searchResults) | |||
There was a problem hiding this comment.
This is unnecessary, inefficient and increases memory usage
…to cache. * Add the season pack's as a valid search result.
p0psicles
force-pushed
the
fix-manual-snatch-keynotfound
branch
from
d061607
to
08ee422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the episode is a key if the searchResults before sending it to cache.