Normalize show status while loading from indexer #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medariox
previously approved these changes
Apr 19, 2017
p0psicles
reviewed
Apr 19, 2017
medusa/indexers/indexer_config.py
Outdated
| 'in production': 'Continuing', | ||
| 'pilot': 'Continuing', | ||
| 'cancelled': 'Ended', | ||
| '': 'Unknown', |
There was a problem hiding this comment.
I don't think you need this. This is redundant now.
p0psicles
reviewed
Apr 19, 2017
medusa/tv/series.py
Outdated
| def normalize_status(series_status): | ||
| """Return a normalized status given current indexer status.""" | ||
| if not series_status: | ||
| return 'Unknown' |
There was a problem hiding this comment.
Or we use this as default unknown status. Or we put it in the STATUS_MAP. So this could be a little bit more DRY.
There was a problem hiding this comment.
But if series_status is None I can't make it lower() as i do in the next line
So what to do?
medariox
reviewed
Apr 19, 2017
medusa/tv/series.py
Outdated
| @staticmethod | ||
| def normalize_status(series_status): | ||
| """Return a normalized status given current indexer status.""" | ||
| return STATUS_MAP.get(series_status.lower()) if series_status else 'Unknown' |
There was a problem hiding this comment.
This will return None if the status is not in the map. Are you sure this is wanted?
p0psicles
approved these changes
Apr 20, 2017
|
This causes all TheTVDB shows to be set to Unknown (try a force update). @fernandog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@medariox @p0psicles