add new config values #4635
add new config values #4635
Conversation
OmgImAlexis
added
Enhancement
Concluded
Needs review
Needs testing
| section_data['nmj']['mount'] = app.NMJ_MOUNT | ||
|
|
||
| section_data['anime'] = NonEmptyDict() | ||
| section_data['anime']['enabled'] = bool(app.ANIMESUPPORT) |
There was a problem hiding this comment.
app.ANIMESUPPORT has no real meaning (it's never used). It's better to just not add it.
| section_data['anime'] = NonEmptyDict() | ||
| section_data['anime']['enabled'] = bool(app.ANIMESUPPORT) | ||
| section_data['anime']['splitHome'] = bool(app.ANIME_SPLIT_HOME) | ||
| section_data['anime']['splitHomeInTabs'] = bool(app.ANIME_SPLIT_HOME_IN_TABS) |
There was a problem hiding this comment.
I wouldn't put these under anime.
I would put these under layout.
Possibly, layout.anime.*
BTW, don't get fooled by the home in the name. I noticed it also affected the show selector.
There was a problem hiding this comment.
We may need to change some of the app var names then. I have a feeling some of the old ones are still there from Sickrage.
There was a problem hiding this comment.
We can do whatever we like inside the app, but we can't change the config.ini key name without a migration.
I'm fine with it for now, I was just stating a fact, to explain why it should be layout.anime and not anime.home.
| @@ -342,6 +340,82 @@ def data_main(): | |||
| section_data['indexers']['config'] = get_indexer_config() | |||
| section_data['processMethod'] = app.PROCESS_METHOD | |||
|
|
|||
| section_data['freeMobile'] = NonEmptyDict() | |||
There was a problem hiding this comment.
There was a different PR where we decided to make a notifications endpoint, didn't we?
Looks like I never opened the PR for it, the branch is bugfix/api-config-patch-multiple.
The commit: 1d66853
You can do this in this PR, instead of put these in data_main make a new function data_notifications and put them there, including kodi, plex and emby.
There was a problem hiding this comment.
Maybe i should do this in #4913
There was a problem hiding this comment.
Let's drop this PR and just move the needed ones to #4913
There was a problem hiding this comment.
Okay just to be clear. In #4913 i'm taking responsibility for moving the notifiers config (for now kodi, plex and emby) to data_notifications. But not the other changes of this PR?!
There was a problem hiding this comment.
Yep, we can re-add these in another PR if still needed.
|
@OmgImAlexis whats the status on this? |
OmgImAlexis
added
Invalid
and removed
Enhancement
Needs review
Needs testing
I can't find anything using it but
animeSplitHomeandanimeSplitHomeInTabsare now apart of theanimefield.