Add ability to manually change episode quality. Fixes #4474 #4658
Conversation
medariox
commented
Jul 12, 2018
medariox
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
medusa/server/web/manage/handler.py
Outdated
| @@ -297,7 +297,7 @@ def downloadSubtitleMissed(self, *args, **kwargs): | |||
| to_download[(cur_indexer_id, cur_series_id)] = [str(x[b'season']) + 'x' + str(x[b'episode']) for x in all_eps_results] | |||
|
|
|||
| for epResult in to_download[(cur_indexer_id, cur_series_id)]: | |||
| season, episode = epResult.split('x') | |||
| season, episode = epResult.lstrip('s').split('e') | |||
There was a problem hiding this comment.
I see a problem here, look at line 297, it's still using the SNxEP format
| <option selected value="">Change quality to:</option> | ||
| <% qualities = sorted(Quality.qualityStrings.items(), key=operator.itemgetter(0)) %> | ||
| % for quality, name in qualities: | ||
| % if quality > 1: # Skip N/A (0) and Unknown (1) |
There was a problem hiding this comment.
I prefer:
% if quality not in (Quality.NA, Quality.UNKNOWN):
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| **New Features** | |||
|
|
|||
| - Hot-swap themes: No need to restart the Medusa after changing the theme ([#4271](https://github.com/pymedusa/Medusa/pull/4271)) | |||
| - Added ability to manually change episode quality ([#4658](https://github.com/pymedusa/Medusa/pull/4658)) | |||
There was a problem hiding this comment.
I wouldn't call it a new feature...
There was a problem hiding this comment.
It was never possible to only change the quality of an episode... so it definitely is IMO.
There was a problem hiding this comment.
But we can also move it to improvements, it's the same for me.
There was a problem hiding this comment.
I feel like improvements would be a better description.
| @@ -414,4 +424,19 @@ MEDUSA.home.displayShow = function() { // eslint-disable-line max-lines | |||
| log.error(error.data); | |||
| }); | |||
| }); | |||
|
|
|||
| function setQuality(quality, seriesSlug, episodes) { | |||
There was a problem hiding this comment.
Please use const setQuality = (quality, seriesSlug, episodes) => {
There was a problem hiding this comment.
Are you sure? That's a really ugly syntax IMO 😕
There was a problem hiding this comment.
How so? That's an arrow function.
The reason I wanted this change was the fact that functions get hoisted and you should avoid that if possible.
There was a problem hiding this comment.
It feels like that at first. But it gets better when your getting used to it
| }); | ||
|
|
||
| api.patch('series/' + seriesSlug + '/episodes', patchData) | ||
| .then(response => { |
There was a problem hiding this comment.
.then should be on the same line as the api.patch.
There was a problem hiding this comment.
If I change it the XO lint won't pass.
There was a problem hiding this comment.
Try
api.patch('series/' + seriesSlug + '/episodes', patchData).then(response => {
log.info(response.data);
window.location.reload();
}).catch(error => {
log.error(error.data);
});
|
Strings can be checked |
|
I hope this won't cause more confusion. For example I changed from |
|
I think where moving to a situation where status and quality should be independent of one another. It gives more flexibility. I think that almost in all places we use the quality As an example the Do we really want to make all these decisions for our users? Like removing the quality when its changed to the status skipped? Users already voiced they want to have that flexibility. |
