Convert titles and headers to VueRouter #4663
Conversation
themes-default/slim/views/home.mako
Outdated
| computed: { | ||
| isRoute() { | ||
| const { matched } = this.$route; | ||
| return matched.filter(route => route.components.default !== undefined).length >= 1; |
There was a problem hiding this comment.
What's this property for?
There was a problem hiding this comment.
It's for the future. It returns true if we have a matched component vs a matched route.
There was a problem hiding this comment.
No for determining if you're in a Vue component or a mako template.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sharkykh
force-pushed
the
feature/vueify-title-and-header
branch
from
770956b
to
4e2a350
Compare
|
I recreated the branch on top of current develop, because we had so many changes (to develop), |
themes-default/slim/views/home.mako
Outdated
| computed: { | ||
| isRoute() { | ||
| const { matched } = this.$route; | ||
| return matched.filter(route => route.components.default !== undefined).length >= 1; |
There was a problem hiding this comment.
Unfortunately I still don't really understand why it's needed.
If you go to /home/displayShow it shouldn't load the home component.
There was a problem hiding this comment.
It can be removed now. I was going to load all the pages differently than how I am now.
sharkykh
force-pushed
the
feature/vueify-title-and-header
branch
from
d2049a0
to
6079d37
Compare
sharkykh
changed the title
sharkykh
force-pushed
the
feature/vueify-title-and-header
branch
from
56c6784
to
c636316
Compare
| @@ -4,12 +4,24 @@ | |||
| from medusa import classes | |||
| %> | |||
| <%block name="scripts"> | |||
|
|
|||
| <% | |||
| if logLevel == logger.WARNING: | |||
There was a problem hiding this comment.
Is this not available via URL params?
There was a problem hiding this comment.
Hmm, yes, I can use that instead.
There was a problem hiding this comment.
Just gets us closer to SFC.
|
The only thing that really bugs me about this PR is the extra router-view component it adds for nested routes.
|
|
@sharkykh if you can find a way to do nested routes without it then by all means suggest away. The way I've used is what has been recommended over and over by the devs. |
* /home/snatchSelection * /home/testRename * /home/postprocess * /home/status
* /addShows/trendingShows * /addShows/popularShows * /addShows/popularAnime
* /news * /changes * /IRC
sharkykh
force-pushed
the
feature/vueify-title-and-header
branch
from
13f5c18
to
f827b36
Compare
|
@OmgImAlexis Last commit 'fixes' it. |
They don't have paths so nothing to add to the router.
| import router from '../../src/router'; | ||
|
|
||
| test('router compiles', t => { | ||
| t.truthy(router); |
There was a problem hiding this comment.
I think notThrows would work better here.
There was a problem hiding this comment.
notThrows requires a function, but the import happens at the top of the file.
Sorry for the single commit.