Add new field watched to tv_episodes table and Episode class. #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated apiv2 to patch the watched field.
…d-episode-watched-status
p0psicles
added
Concluded
Migration
medariox
reviewed
Aug 10, 2018
medusa/databases/main_db.py
Outdated
| 'version, release_group, manually_searched, watched) ' | ||
| 'SELECT showid, indexerid, indexer, ' | ||
| 'name, season, episode, description, airdate, hasnfo, ' | ||
| 'hastbn, status, -1 AS quality, location, file_size, release_name, ' |
There was a problem hiding this comment.
I don't understand why you are changing the quality fields to -1?
medariox
reviewed
Aug 10, 2018
medusa/databases/main_db.py
Outdated
| @@ -699,7 +699,7 @@ def execute(self): | |||
| utils.backup_database(self.connection.path, self.connection.version) | |||
|
|
|||
| log.info(u'Adding new quality field in the tv_episodes table') | |||
| self.connection.action('DROP TABLE IF EXISTS old_tv_episodes;') | |||
| self.connection.action('DROP TABLE IF EXISTS tmp_tv_episodes;') | |||
There was a problem hiding this comment.
I don't think this should have been renamed.
There was a problem hiding this comment.
Trying to keep it consistant. Also tmp is a better description then old. As where not dealing with 'old' episodes.
There was a problem hiding this comment.
In that case you should also replace it in the next line.
medusa/databases/main_db.py
Outdated
| 'FROM tmp_tv_episodes;' | ||
| ) | ||
|
|
||
| self.connection.action('DROP TABLE tmp_tv_episodes') |
There was a problem hiding this comment.
Trailing semicolon for consistency.
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| #### Improvements | |||
| - Converted /config/postProcessing to a Vue component ([#4259](https://github.com/pymedusa/Medusa/pull/4259)) | |||
| - Bundled the web application using Webpack ([#4692](https://github.com/pymedusa/Medusa/pull/4692)) | |||
| - Add watched field to the tv_episodes db table. UI will be added in future. ([#4692](https://github.com/pymedusa/Medusa/pull/4825)) | |||
There was a problem hiding this comment.
Use past tense for consistency.
medusa/databases/main_db.py
Outdated
| 'hastbn, status, quality, location, file_size, release_name, ' | ||
| 'subtitles, subtitles_searchcount, subtitles_lastsearch, ' | ||
| 'is_proper, scene_season, scene_episode, absolute_number, ' | ||
| 'scene_absolute_number, version, release_group, manually_searched, 0 ' |
There was a problem hiding this comment.
Maybe 0 AS watched to make it more explicit.
medariox
approved these changes
Aug 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea of this feature, is provide users the ability to keep track of watched / unwatched episodes.
They'll be able to manually set the status from medusa. Or automate it through the medusa kodi addon.
For now this PR will be limited to introducing the watched field. A new PR will be used to make some UI changes. As to update the watched flag manually.
TODO: