Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python3] Several changes to migrate the code to python3 (part 3) #4982

Merged
merged 116 commits into from
Dec 22, 2018

Conversation

ngosang
Copy link
Contributor

@ngosang ngosang commented Aug 27, 2018

This PR contains the commits from #4985 and #4980. After other PRs are merged this PR will be rebased.
This PR is the 3rd in [Python3] series and the first one with python3 support.
Main discussion: #4975

You wanna help?

  • Test with python2. Everything should work as usual.
  • Test with python3. Main features are working. Report all problems you found (trace + python version)
  • Request other people to test!

Instructions to test

  • git clone https://github.com/ngosang/Medusa.git
  • cd Medusa
  • git pull and git checkout feature/py3_2
  • edit config.ini and change debug = 1
  • python -V or python2 -V or python3 -V
  • python start.py or python2 start.py or python3 start.py
  • Try to enable/configure all features in the webui

Known bugs

Disclaimer:

I'm testing careful with both python2 and python3 interpreters. With python2 you should expect the same functionally than development branch. Python3 is a long term goal, first versions won't be functional or even won't run.

lib/tvdbapiv2/api_client.py Outdated Show resolved Hide resolved
@ngosang ngosang force-pushed the feature/py3_2 branch 2 times, most recently from 61010cf to 4cf7ada Compare August 27, 2018 23:30
@OmgImAlexis OmgImAlexis added Enhancement Needs review Needs testing Requires testing to make sure it's working as intended Do not merge Needs test (Vue) Needs tests added for this change (Vue) Needs test (Python) Needs tests added for this change (Python) Backend labels Aug 27, 2018
@OmgImAlexis OmgImAlexis added this to the 0.2.10 milestone Aug 27, 2018
@OmgImAlexis OmgImAlexis assigned p0psicles and medariox and unassigned p0psicles and medariox Aug 27, 2018
@ngosang ngosang changed the title [WIP] [Python3] Several changes to migrate the code to python3 [WIP] [Python3] Several changes to migrate the code to python3 (part 3) Aug 28, 2018
@OmgImAlexis OmgImAlexis added Changelog Requires a changelog entry and removed Changelog Requires a changelog entry labels Aug 28, 2018
@ngosang ngosang force-pushed the feature/py3_2 branch 7 times, most recently from c5a35ff to 052b5d0 Compare August 28, 2018 17:47
@p0psicles
Copy link
Contributor

@medariox 1d347d8 and ec25183

Tested deluge-web. Couldn't get deluged to work in docker.

@labrys
Copy link
Contributor

labrys commented Dec 18, 2018

@medariox @p0psicles @duramato and any others:

There have been some major changes to nzbtomedia in nightly, with more to come. It now fully supports Python 3. If any of you have the time to test the changes in nightly and report any issues it would be greatly appreciated.

@medariox
Copy link
Contributor

@labrys
I don't use NZBs, but I tried using nightly with TorrentToMedia.py and got this exception:

python C:\Users\Dario\Desktop\nzbToMedia\TorrentToMedia.py C:\Users\Dario\Desktop\sed
Traceback (most recent call last):
  File "C:\Users\Dario\Desktop\nzbToMedia\core\nzbToMediaUtil.py", line 1324, in __init__
    from win32.win32event import CreateMutex
ImportError: DLL load failed: %1 is not a valid Win32 application.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Dario\Desktop\nzbToMedia\TorrentToMedia.py", line 368, in <module>
    exit(main(sys.argv))
  File "C:\Users\Dario\Desktop\nzbToMedia\TorrentToMedia.py", line 287, in main
    core.initialize()
  File "C:\Users\Dario\Desktop\nzbToMedia\core\__init__.py", line 261, in initialize
    MYAPP = RunningProcess()
  File "C:\Users\Dario\Desktop\nzbToMedia\core\nzbToMediaUtil.py", line 1307, in __init__
    self.process = WindowsProcess()
  File "C:\Users\Dario\Desktop\nzbToMedia\core\nzbToMediaUtil.py", line 1328, in __init__
    from win32event import CreateMutex
ModuleNotFoundError: No module named 'win32event'

Running Windows 10 and Python 3.6.7

p0psicles
p0psicles previously approved these changes Dec 19, 2018
@p0psicles
Copy link
Contributor

@medariox still needs a changelog

@medariox medariox added Concluded and removed Changelog Requires a changelog entry Do not merge In progress Needs test (Python) Needs tests added for this change (Python) Needs test (Vue) Needs tests added for this change (Vue) Squash / Rebase labels Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concluded Enhancement Needs review Needs testing Requires testing to make sure it's working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants