Initial version_checker refactor #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
medariox
commented
Jan 16, 2019
medariox
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
|
DeepCode analyzed this pull request. |
|
DeepCode analyzed this pull request. |
Closed
|
Fixes #5726 |
|
Docker installs will compare the current installed version with the latest release on GitHub. I think that is what you meant @p0psicles |
p0psicles
reviewed
Jan 23, 2019
medusa/updater/update_manager.py
Outdated
|
|
||
|
|
||
| class UpdateManager(object): | ||
| def __init__(self): |
There was a problem hiding this comment.
Init is not required here right? It's not doing anything.
p0psicles
reviewed
Jan 23, 2019
|
|
||
| def is_latest_version(self): | ||
| """Compare the current installed version with the remote version.""" | ||
| if LooseVersion(self.newest_version) > LooseVersion(self.current_version): |
There was a problem hiding this comment.
newest_version and current_version don't refer to anything in this class. Imo it's cleanest to add them in UpdateManager, as methods and raise exception when not implemented subclassed. Like:
def newest_version(self):
"""Docstring"""
raise NotImplmentedError
def current_version(self):
raise NotImplmentedError
labrys
suggested changes
Jan 24, 2019
|
@labrys That's right, it's what we want. |
p0psicles
approved these changes
Jan 24, 2019
|
@medariox lol I was agreeing with you. I'm saying its a good design choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.