Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added provider Beyond-HD #6802

Merged
merged 8 commits into from
Jun 12, 2019
Merged

Added provider Beyond-HD #6802

merged 8 commits into from
Jun 12, 2019

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Jun 8, 2019 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

implemented #6766

@sharkykh sharkykh changed the title Added provider behond-hd Added provider beyond-hd Jun 9, 2019
@sharkykh sharkykh changed the title Added provider beyond-hd Added provider Beyond-HD Jun 9, 2019
medariox
medariox reviewed Jun 10, 2019
View reviewed changes
medusa/providers/torrent/html/beyondhd.py Outdated
self.proper_strings = ['PROPER', 'REPACK', 'REAL', 'RERIP']

# Miscellaneous Options
self.freeleech = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The freeleech option is not needed I think. There is nothing in the code that actually filters freeleech results.

medariox
medariox approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@medariox medariox mentioned this pull request Jun 12, 2019
Closed
@medariox medariox merged commit ca5a6e2 into develop Jun 12, 2019
@medariox medariox deleted the feature/provider-behond-hd branch June 12, 2019 16:15
@p0psicles
Copy link
Contributor Author

Tnx. I just checked. But the provider has never had a freeleech for a TV show. Only movies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkykh sharkykh sharkykh left review comments

@medariox medariox medariox approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0psicles @medariox @sharkykh