Add field identfier to provider cache tables.
#7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently by default use the url for the identifier. In future this can be overwritten per provider.
The method can be overwritten per provider.
p0psicles
commented
Nov 3, 2019
medusa/providers/generic_provider.py
Outdated
| @@ -781,6 +781,18 @@ def _get_title_and_url(self, item): | |||
|
|
|||
| return title, url | |||
|
|
|||
| def _get_identifier(self, item): | |||
There was a problem hiding this comment.
@medariox if you want to try it out. You'll have to copy this method into the provider, where you want to set the identifier. I can try it for binsearch. But you know more about the jacket stuff.
* Fix checking/storing by identifier
medariox
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently by default use the url for the identifier. In future this can be overwritten per provider.
NOTE! This change will remove all provider cache tables, you will lose your cache
This could in the future fix providers like jacket and binsearch #7304