Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qBittorrent client maintenance #7474

Merged
merged 9 commits into from
Dec 12, 2019
Merged

qBittorrent client maintenance #7474

merged 9 commits into from
Dec 12, 2019

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Dec 11, 2019

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Related:

Fixes:


Tested with:

qBittorrent version Highest API version
v4.2.0 v2.3.0
v4.0.4 v17 (v1.17.0)
v3.1.12 v1 (v1.0.0)

@sharkykh sharkykh added Bug In progress Changelog Requires a changelog entry labels Dec 11, 2019
- Warn when username/password is invalid.
- Warn when your IP is banned by the client (after too many failed authentication attempts).
@sharkykh sharkykh added Concluded and removed Changelog Requires a changelog entry In progress labels Dec 12, 2019
@sharkykh sharkykh added this to the 0.3.8.1 milestone Dec 12, 2019
@sharkykh sharkykh changed the title WIP: qBittorrent client maintenance qBittorrent client maintenance Dec 12, 2019
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me (Windows 10). Thanks 👍

@medariox medariox merged commit 7d81f25 into develop Dec 12, 2019
@medariox medariox deleted the bugfix/qbittorrent branch December 12, 2019 10:09
fernandog pushed a commit to fernandog/Medusa that referenced this pull request Jan 11, 2020
* Warn when you need to create the label first

* Handle API authentication errors better

- Warn when username/password is invalid.
- Warn when your IP is banned by the client (after too many failed authentication attempts).

* Fix incorrect API version format

* Update `_get_auth` docstring

* Rename client

* Use `urljoin`

* Rewrite API authentication and version-getting

* Update changelog

* Restore authentication test functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants