-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update thread to write to mda zarr #264
Conversation
The private _sequence module definitely shouldn't be imported here. Let's talk about what you need to accomplish and make it public if there's no other way |
Sure :) I'm doing some tests with your sequencable PR and it's awesome!!! I pushed this commit to not loose the testing progress :) |
@fdrgsp can you please make this a separate self contained PR. Wrapping it up in a big PR like this makes it difficult for me to work on other things (and led to me thinking this was an unfixed bug: #268) |
…micromanager into update_io_threads
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 75.24% 77.52% +2.28%
==========================================
Files 15 15
Lines 820 801 -19
==========================================
+ Hits 617 621 +4
+ Misses 203 180 -23
☔ View full report in Codecov by Sentry. |
closing. Open a simpler version #272. |
followup of #258.
In this PR I've updated the code with the suggestions in #258 + I've added a method (
_process_remaining_frames
) that is used to add to the zarr layer(s) any frames remaining in_deck
after the acquisition is finished. Note that at the moment, since we don't have a proper writer innapari-micromanager
this method is called by_on_mda_finished
but once we have a writer, we can simply link this method to_io_thread
_connect
("finished": self._process_remaining_frames
).To speed up the process it was also necessary to specify the chunk size when creating the zarr.
I did few test on our microscope and this way of handling the acquired images works great!
In addition I've added some fixes for the use of the current
pymmcore-widgets
(main git branch).Test failing until new release of
pymmcore-widgets
.closes #258.