-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use widget from pymmcore-widgets main branch #269
Conversation
This raises the question of the dependency structure of the testing between these two repos. Would it maybe make more sense to do the following?
It seems that that would allow smooth development, but still make sure released versions are compatible. |
the structure I prefer is for upstream libraries to test against the main branch of their dependents with
While the downstream libraries test against the current release (NOT against the main branch). I know you've just jumped into an odd state, but we're actively working on this and you just caught us at a funny time. |
self.position_groupbox.isChecked() | ||
and len(self.position_groupbox.value()) > 0 | ||
not self.channel_widget.value() | ||
or self.channel_widget._table.rowCount() == 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a usage of a private widget in pymmcore-widgets. If there is literally no public way to access this and you need it here, then you should make it public in pymmcore-widgets
(or make some sort of public method)
…ri-micromanager into fix_with_newest_wdgs
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 76.11% 75.24% -0.88%
==========================================
Files 15 15
Lines 804 820 +16
==========================================
+ Hits 612 617 +5
- Misses 192 203 +11
☔ View full report in Codecov by Sentry. |
Hooray, seeing some green lights here |
@ianhi linked to #264 (comment)
This PR updates
napari-micromanager
using thepymmcore-widgets
in main branch.