Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff-specific rules #1481

Merged
merged 8 commits into from
Apr 10, 2023
Merged

Enable ruff-specific rules #1481

merged 8 commits into from
Apr 10, 2023

Conversation

alexrudd2
Copy link
Collaborator

Enable ruff-specific "RUF" rules.

In the case of RUF006, this is only relevant when garbage collection occurs. The two places where this rule triggered are not-lived enough to worry about GC (IMO), so I silenced them instead.

Note! This is branched off #1480

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

I do not like silencing, but I agree with you here.

@janiversen janiversen merged commit f2a668a into dev Apr 10, 2023
@janiversen janiversen deleted the ruff-builtin branch April 10, 2023 06:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants