Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings for dune-gdt #1381

Closed
wants to merge 29 commits into from
Closed

bindings for dune-gdt #1381

wants to merge 29 commits into from

Conversation

ftalbrecht
Copy link
Contributor

@ftalbrecht ftalbrecht commented Sep 9, 2021 •
edited
Loading

This adds a discretizers based on dune-gdt which can discretize analytical problems from pyMOR, superseding #969 . Still to do:

  • ensure vectorarray tests pass
  • ensure vector-valued interpolation of data functions is working
  • ensure code is working with current time steppers
  • ensure shifting of Dirichlet-values matches current state in pyMOR
  • ensure IPDG discretizers work as well as CG ones
  • adress issues raised in dunegdt bindings #969

@ftschindler
[config] HAVE_DUNEXT, HAVE_DUNEGDT
dc8d717
@ftschindler
[discretizers.dunegdt] add discretize_domain_default
a2cc8cf
@ftschindler
[analyticalproblems] add CubeDomain
051f642
@ftschindler
[bindings.dunext] bring up to date
31d6ce3
@ftschindler
[bindings.dunegdt] bring up to date and add notebook visualizer
eb22aee
@ftschindler
[discretizers.dunegdt...] default to cubes as YaspGrid is always avai…
8107b1c 
…lable
@ftschindler
[discretizers.dunegdt.cg] add discretize_stationary_cg
33e211e
@ftschindler
[discretizers.dunegdt] use GridFunction to simplify integrand constru…
0d0bccf 
…ction
@ftschindler
[bindings] merge dunext into dunegdt
dfd3a9f
@ftschindler
[bindings.dunegdt] fix 1d vtk filename
85a0a23
@ftschindler
[bindings.dunegdt] add 1d P1 matplotlib visualizer
d16f3da
@ftschindler
[...dunegdt.cg] some fixes
ac08054
@ftschindler
[...dunegdt.ipdg] add NIPDG, IIPDG, SIPDG and SWIPDG discretizer
d400ebc
@ftschindler
[discretizers.dunegdt] update integrand use
e8a5754
@ftschindler
[bindings.dunegdt] update to match VectorArray API
018c5df
@ftschindler
[discretizer.dunegdt] update CG variant, not fully generic yet
fe71646
@ftschindler
[bindings.dunegdt] add wrapped OnedVisualizer
4ee7cba
@ftschindler
[discretizers.dunegdt] add discretize_instationary_cg, docs not good yet
830b592
@ftschindler
[bindings.dunegdt] do not tro to complexify
f7a5644
@ftschindler
[discretizers.dunegdt.cg] fix total flux BC for arbitrary advec/Neumann
2a95a41
@ftschindler
[discretizers.dunegdt] fix non-0 Neumann data handling
411a2dd
@ftschindler
fix typo
219971f
@ftschindler
[bindings.dunegdt] add to_numpy() to DuneXTVector
166edd1
@ftschindler
[discretizers.dunegdt] improve CG
19d0836 
- allow to treat both linear advection formulations
- allow to assemble energy product
- add some automatic simplifications
@ftschindler
[bindings.dunegdt] fix vector_from_numpy()
2b8fad3
@ftschindler
[discretizers.dunegdt] update product assembly
b8d92ac
@ftschindler
[discretizers.dunegdt] fix assembly of trivial RHS
3eaa78c
@ftschindler
[discretizers.dunegdt] guard by correct indentation
4cc45bd
@ftschindler
[discretizers.dunegdt] take care of shifting initial values
248d0e1
@ftalbrecht ftalbrecht added the pr:new-feature Introduces a new feature label Sep 9, 2021
@ftalbrecht ftalbrecht added this to the 2021.2 milestone Sep 9, 2021
@ftalbrecht ftalbrecht self-assigned this Sep 9, 2021
renefritze
renefritze reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@renefritze renefritze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have time to look into the implementation details yet.

What do you think about breaking this down into two PRs? The first with only the data bindings stuff. There I could add VectorArray tests for the binding. Which also needs CI updates. And based on that PR then a second PR with the discretizer / domain stuff?

src/pymor/bindings/dunegdt.py Show resolved Hide resolved
src/pymor/bindings/dunegdt.py Show resolved Hide resolved
src/pymor/bindings/dunegdt.py Show resolved Hide resolved
src/pymor/bindings/dunegdt.py Show resolved Hide resolved
src/pymor/bindings/dunegdt.py Show resolved Hide resolved
src/pymor/core/config.py Show resolved Hide resolved
src/pymor/discretizers/dunegdt/cg.py Show resolved Hide resolved
@sdrave
Copy link
Member

sdrave commented Sep 9, 2021

Didn't have time to look into the implementation details yet.

What do you think about breaking this down into two PRs? The first with only the data bindings stuff. There I could add VectorArray tests for the binding. Which also needs CI updates. And based on that PR then a second PR with the discretizer / domain stuff?

I agree. I think the review process would be much easier if the discretizer stuff is separated from the rest.

@ftalbrecht ftalbrecht modified the milestones: 2021.2, 2021.1 Sep 9, 2021
@ftalbrecht ftalbrecht mentioned this pull request Sep 10, 2021
Merged
10 tasks
@ftalbrecht ftalbrecht closed this Sep 10, 2021
@ftalbrecht ftalbrecht deleted the dunegdt-bindings branch September 10, 2021 10:50
This was referenced Sep 13, 2021
Open
Closed
ftalbrecht pushed a commit that referenced this pull request May 30, 2022
@ftschindler
[discretizers...dunegdt] add NIPDG, IIPDG, SIPDG and SWIPDG discretizer
a87a14d 
This adds discretizers/dunegdt/ipdg.py from d400ebc from #1381.
TiKeil pushed a commit that referenced this pull request May 17, 2023
@ftschindler
[discretizers...dunegdt] add NIPDG, IIPDG, SIPDG and SWIPDG discretizer
7d299db 
This adds discretizers/dunegdt/ipdg.py from d400ebc from #1381.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renefritze renefritze renefritze left review comments

@sdrave sdrave Awaiting requested review from sdrave

Assignees

@ftalbrecht ftalbrecht

Labels
pr:new-feature Introduces a new feature
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ftalbrecht @sdrave @renefritze @ftschindler