Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings for dune-gdt (part 2: discretizers) #1387

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

ftalbrecht
Copy link
Contributor

@ftalbrecht ftalbrecht commented Sep 13, 2021

Together with part 1 (#1383), this supersedes #1381.

  • ensure vector-valued interpolation of data functions is working
  • move visualizers from bindings/dunegdt.py to discretizers/dunegdt/gui.py?
  • move interpolation and data function handling out of discretizers to share code?
  • ensure code is working with current time steppers
  • disable shifting of Dirichlet-values to match Add StationaryModel.deaffinize #1410
  • ensure IPDG discretizers work as well as CG ones
  • adress issues raised in dunegdt bindings #969
  • ensure visualization works in notebooks + offline (e.g. use Use pyvista for Qt based visualizations #1402, cherry-pick 4b13a94, delete dunegdt-discretizers-pyvista branch afterwards)
  • ensure docs
  • require newer dune wheels
  • ensure passing tests
  • ensure demo
  • ensure rebase on main after bindings for dune-gdt (part 1: bindings) #1383 has been merged

@ftalbrecht ftalbrecht added the pr:new-feature Introduces a new feature label Sep 13, 2021
@ftalbrecht ftalbrecht added this to the 2021.1 milestone Sep 13, 2021
@ftalbrecht ftalbrecht self-assigned this Sep 13, 2021
@github-actions github-actions bot added the infrastructure Buildsystem, packages and CI label Sep 13, 2021
@ftalbrecht ftalbrecht changed the title bindings for dune-gdt: part 2 bindings for dune-gdt (part 2: discretizers) Sep 13, 2021
@ftalbrecht ftalbrecht mentioned this pull request Sep 13, 2021
@ftalbrecht
Copy link
Contributor Author

CI depends on pymor/docker#81

@ftalbrecht
Copy link
Contributor Author

Just in case this makes it into the release: what is your opinion regarding the Dirichlet data in this pr, @sdrave? I am currently shifting the model to solve in the H^1_0 subspace and adapt the visualizer accordingly. Should I simply return the solution with the correct Dirichlet data as the other CG discretizers do?

@sdrave
Copy link
Member

sdrave commented Sep 22, 2021

Won't get this done before the release.

@renefritze
Copy link
Member

I've rebased this on main just now, @ftalbrecht. The new visualization stuff will not land in 2021.2. Did you look into the dummy visualization/vtu download we discussed elsewhere?

@sdrave
Copy link
Member

sdrave commented Dec 17, 2021

Also moving to next release.

@sdrave sdrave modified the milestones: 2021.2, 2022.1 Dec 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

Unit Test Results

6 files  6 suites   1m 18s ⏱️
1 tests 0 ✔️ 0 💤 0  1 🔥
6 runs  0 ✔️ 0 💤 0  6 🔥

For more details on these errors, see this check.

Results for commit 8433553.

@ftalbrecht
Copy link
Contributor Author

@TiKeil reports to have working k3d visualization with K3D==2.6.6.

@ftalbrecht
Copy link
Contributor Author

I re-based on current main to get things rolling again.

@ftalbrecht
Copy link
Contributor Author

Try installing "pymor[full]" and then gdt, see what gets installed?

In a fresh 3.9 virtualenv, doing

pip install -e '.[full]'
pip freeze | ack multidict

in this branch gives multidict==6.0.2, so this is fine. Installing

pip install dune-gdt[visualisation]

afterwards does not change this.

Similarly, in a fresh 3.9 virtualenv, running

pip install -e '.[full]' dune-gdt[visualisation]
pip freeze | ack multidict

yields the same. So pymor and dune-gdt seem to agree on the multidict version, and I deduce that its a problem of our CI setup.
Looking at the logs of the failure, the first line mentioning multidict is

Collecting multidict<5.0,>=4.5

which is already a bad version requirement (due to lacking wheels). This is triggered by the call

devpi install pymor[full]

which is evaluated to

/builds/pymor/pymor$ /usr/local/bin/pip install -U -i http://pymor__devpi:3141/root/public/+simple/ pymor[full]  [PIP_PRE=1,PIP_USE_WHEEL=1]

@ftalbrecht
Copy link
Contributor Author

Rebasing on current main again to see if this helps in the CI. Needs a restart after image updates are through.

@ftalbrecht
Copy link
Contributor Author

Current CI failures are due to pyside problems. Ideas, @renefritze?

@renefritze
Copy link
Member

The check says an unexpected version of pyside is installed in the image. Is the docker image based on current main image? Does the visualization extra pull in a fixed version of pyside?

@pmli pmli modified the milestones: 2022.1, 2022.2 Jun 7, 2022
@renefritze renefritze linked an issue Jul 5, 2022 that may be closed by this pull request
@sdrave sdrave modified the milestones: 2022.2, 2023.1 Nov 28, 2022
@TiKeil
Copy link

TiKeil commented Dec 13, 2022

In the ipdg discretizer, the weighted_h1_semi_penalty-product does not seem to be symmetric and always incorporates Dirichlet terms.

@sdrave sdrave force-pushed the main branch 4 times, most recently from 18e66f2 to e80291b Compare March 7, 2023 20:03
@pmli pmli modified the milestones: 2023.1, 2023.2 May 10, 2023
@pmli pmli removed this from the 2023.2 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Buildsystem, packages and CI pr:new-feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visualization of dune-gdt data
6 participants