Discretizing robin boundary conditions on a RectGrid #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently discretizing a problem with a robin boundary condition on a RectGrid raises a NotImplementedError. Replacing
NI = bi.neumann_boundaries(1)
in line 310 in operators.cg withNI = bi.boundaries(self.boundary_type, 1) if self.boundary_type else g.boundaries(1)
as in line 136 worked as a fix for me.Since then
BoundaryL2ProductFunctionalP1
andBoundaryL2ProductFunctionalQ1
are basically the same, it might be an idea to have just oneBoundaryL2ProductFunctional
.Example: