Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'order' arguments from CG operators #691

Merged
merged 1 commit into from May 27, 2019
Merged

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented May 24, 2019

This PR simplifies the implementation in operators.cg by removing the optional integration order arguments from all Operators. All data functions are now evaluated at the entity centers, corresponding to the mid-point integration rule. For the implemented first-order schemes this should be sufficient (assuming regularity of the coefficient functions).

For discontinuous diffusion tensors, it is now in particular clear, that these are approximated by entity-wise constant functions (given by evaluation at the entity centers).

@sdrave sdrave added pr:removal builtin-models labels May 24, 2019
@sdrave sdrave added this to the 2019.2 milestone May 24, 2019
@sdrave
Copy link
Member Author

@sdrave sdrave commented May 24, 2019

Any remarks, @renefritze, @ftalbrecht, @deneick?

@renefritze
Copy link
Member

@renefritze renefritze commented May 27, 2019

Not sure that I follow the reasoning. Isn't this removing high order evaluation of smooth data tensors, which can greatly impact accuracy, just so that the user might not incorrectly evaluate disc. tensors?

@sdrave
Copy link
Member Author

@sdrave sdrave commented May 27, 2019

@renefritze, the schemes are all first order. A quadrature is of sufficient order, when the error due to inexact quadrature is of the same order as the error due to discretization. If I haven't overlooked something, the used quadratures should be of sufficient order.

@renefritze
Copy link
Member

@renefritze renefritze commented May 27, 2019

Ah, sorry, I misremembered then. I thought the CG scheme was implemented with variable order too.

@sdrave sdrave merged commit 87db363 into master May 27, 2019
7 checks passed
@sdrave sdrave deleted the disc_remove_order branch May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants