Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge FunctionBase into Function #867

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Merge FunctionBase into Function #867

merged 1 commit into from
Feb 4, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jan 31, 2020

Similar to what we did with OperatorBase, this PR merges the default implementations of FunctionBase into the Function interface class.

@sdrave sdrave added pr:removal Removes a feature implementation labels Jan 31, 2020
@sdrave sdrave added this to the 2020.1 milestone Jan 31, 2020
@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #867 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/pymor/analyticalproblems/functions.py 94.85% <100%> (-0.04%) ⬇️

@sdrave sdrave merged commit 688650b into master Feb 4, 2020
@sdrave sdrave deleted the remove_functionbase branch February 4, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:removal Removes a feature
Projects
None yet
Milestone
2020.1
Development

Successfully merging this pull request may close these issues.
1 participant
@sdrave