Utils.metrics added functionality #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2014 22:29
It is now a module level function so it can be used universally outside of perfdatametrics. Conflicts: pynag/Plugins/relational_thresholds.py pynag/Utils/metrics.py
palli
added a commit
that referenced
this pull request
Dec 15, 2014
Utils.metrics added functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a remake of #200 but getting rid of those 2 extra commits that sneaked into it by accident)
2 patches changes in this pull request:
a) states.PerfdataMetric.split_value_and_uom() moved to be a module level function instead of a method of PerfdataMetric
b) new function get_base_value() designed for common arithmetic like convert gigabytes into bytes.