Workaround for botocore 1.28 (round 2) #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
force-pushed
the
2022-10-25-_resolve_endpoint_ruleset
branch
2 times, most recently
from
99f1065
to
1ccf5ac
Compare
ikonst
force-pushed
the
2022-10-25-_resolve_endpoint_ruleset
branch
from
1ccf5ac
to
50c57eb
Compare
garrettheel
approved these changes
Oct 25, 2022
ikonst
added a commit
that referenced
this pull request
Oct 25, 2022
In #1083 we've started passing an `endpoint_url` parameter to _convert_to_request_dict due to changes made in botocore 1.28. When a model does not specify a `host`, the `endpoint_url` would be `None`. To determine the actual `endpoint_url` in botocore ≥1.28, we must call another private method, `_resolve_endpoint_ruleset`.
Closed
This was referenced Dec 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1083 we've started passing an
endpoint_urlparameter to_convert_to_request_dictdue to changes made in botocore 1.28.All of our integration tests have an explicit
host, and all our unit tests either mock_make_api_callentirely or mock the botocore client, so we didn't realize thatendpoint_urlcannot beNone. To determineendpoint_urlin botocore ≥1.28, we must call another private method,_resolve_endpoint_ruleset.