Support document paths and attribute names containing dot characters. #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for both Document Paths and '.' characters in expressions.
Expressions are generated assuming that the path given in the object is a document path;
for example,
Path('foo.bar.baz[0]') == value
is translated into#0.#1.#2[0] = :0
with the following expression attribute names:{'#0': 'foo', '#1': 'bar', "#2': 'baz'}
.With this change, expressions generated from Attribute objects will use whatever attribute name is defined by the
attr_name
field, allowing support for dotted attribute names; for example,ListAttribute(attr_name='foo.bar.baz')[0] == value
is translated into#0[0] = :0
with the following expression attribute names:{'#0: 'foo.bar.baz'}
.