Support document paths and attribute names containing dot characters. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinner-lyft
force-pushed
the
document-paths
branch
4 times, most recently
from
e6cf622
to
2d2b5f7
Compare
jpinner-lyft
force-pushed
the
document-paths
branch
11 times, most recently
from
4348830
to
053fe03
Compare
jpinner-lyft
force-pushed
the
document-paths
branch
4 times, most recently
from
884f38e
to
cbfdfc8
Compare
jpinner-lyft
force-pushed
the
document-paths
branch
from
cbfdfc8
to
b9f0335
Compare
jmphilli
reviewed
Aug 8, 2017
| def __init__(self, attribute, prefix): | ||
| super(BeginsWith, self).__init__(attribute, 'begins_with', prefix) | ||
| def __init__(self, path, prefix): | ||
| super(BeginsWith, self).__init__(path, 'begins_with', prefix) |
There was a problem hiding this comment.
the current BEGINS_WITH const is for the old api which is capitalized and not lowercase
jmphilli
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for both Document Paths and '.' characters in expressions.
Expressions are generated assuming that the path given in the object is a document path;
for example,
Path('foo.bar.baz[0]') == valueis translated into#0.#1.#2[0] = :0with the following expression attribute names:{'#0': 'foo', '#1': 'bar', "#2': 'baz'}.With this change, expressions generated from Attribute objects will use whatever attribute name is defined by the
attr_namefield, allowing support for dotted attribute names; for example,ListAttribute(attr_name='foo.bar.baz')[0] == valueis translated into#0[0] = :0with the following expression attribute names:{'#0: 'foo.bar.baz'}.