Fix bug in matching across where multiple target halos exist #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some circumstances, matching across into another simulation could result in too many results being generated (and an exception being thrown), because at the final stage the maximum weight criterion was not being applied correctly. The resolution involves fixing an argmax to be grouped only by source halo, not the most recent hop. Added also a useful printing routine for debugging issues with multisource/multihop calculations (disabled by default, of course!)
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances, matching across into another simulation could result in
too many results being generated (and an exception being thrown), because at
the final stage the maximum weight criterion was not being applied correctly.
The resolution involves fixing an argmax to be grouped only by source halo,
not the most recent hop.
Added also a useful printing routine for debugging issues with multisource/multihop
calculations (disabled by default, of course!)